Appending Pulumi APN 1.1 marketplace id to User Agent request header #5920
Conversation
pose
changed the title
There was a problem hiding this comment.
I don't think this should be changing, but it looks like it's just the tests so maybe it's fine.
There was a problem hiding this comment.
Yes, the issue is that somehow the diff moved the functions around. Not sure why the diff generation is not stable. I didn't modify any of these files as part of my change.
guineveresaenger
left a comment
guineveresaenger
left a comment
There was a problem hiding this comment.
While we can merge this as-is, we do need to actually also update the workflow changes that pertain to version gating here.
We can merge as-is, but we wouldn't be able to tag the release safely.
pulumi/ci-mgmt#1808 will only pertain to current default going forwards.
…releases are pushed manually and should not use release label automation.
|
update: I've pushed the two tweaks to prevent Requested a review from the rest of the team. |
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v6-security-patch #5920 +/- ##
======================================================
- Coverage 24.45% 12.72% -11.73%
======================================================
Files 367 366 -1
Lines 148274 81097 -67177
======================================================
- Hits 36253 10319 -25934
+ Misses 111922 70759 -41163
+ Partials 99 19 -80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Re-running failed CI jobs as they seem unrelated to the change. |
|
Re-running again failed jobs. |
|
Build has passed and this is now ready to merge. Not sure what our policy is but I am always hesitant doing releases/deployments on Friday. @guineveresaenger do you think we can go over this on Monday? 🙏 Thanks |
Part of https://github.com/pulumi/home/issues/4348
Backport the APN 1.1 marketplace change to v6: #5910